binary tree using traversal lists#13774
binary tree using traversal lists#13774Sai-Adithya-M wants to merge 6 commits intoTheAlgorithms:masterfrom
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
algorithms-keeper
bot
added
require tests
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| self.parent: Node | None = None | ||
|
|
||
|
|
||
| def inorder_traversal(root: Node | None, out: list[int]) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/build_tree_from_traversal.py, please provide doctest for the function inorder_traversal
| inorder_traversal(root.right, out) | ||
|
|
||
|
|
||
| def _build_tree_from_preorder( |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/build_tree_from_traversal.py, please provide doctest for the function _build_tree_from_preorder
| return root | ||
|
|
||
|
|
||
| def build_tree_from_preorder(inorder: list[int], preorder: list[int]) -> Node | None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/build_tree_from_traversal.py, please provide doctest for the function build_tree_from_preorder
| return root | ||
|
|
||
|
|
||
| def build_tree_from_postorder(inorder: list[int], postorder: list[int]) -> Node | None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/build_tree_from_traversal.py, please provide doctest for the function build_tree_from_postorder
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| self.parent: Node | None = None | ||
|
|
||
|
|
||
| def inorder_traversal(root: Node | None, out: list[int]) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/build_tree_from_traversal.py, please provide doctest for the function inorder_traversal
| inorder_traversal(root.right, out) | ||
|
|
||
|
|
||
| def _build_tree_from_preorder( |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/build_tree_from_traversal.py, please provide doctest for the function _build_tree_from_preorder
| return root | ||
|
|
||
|
|
||
| def build_tree_from_preorder(inorder: list[int], preorder: list[int]) -> Node | None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/build_tree_from_traversal.py, please provide doctest for the function build_tree_from_preorder
| return root | ||
|
|
||
|
|
||
| def build_tree_from_postorder(inorder: list[int], postorder: list[int]) -> Node | None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/build_tree_from_traversal.py, please provide doctest for the function build_tree_from_postorder
algorithms-keeper
bot
removed
the
tests are failing
1 participant
Describe your change:
Checklist: