Refactor quick_sort to use in-place sorting for improved space comple…#13837
Closed
MathewAddala wants to merge 1 commit intoTheAlgorithms:masterfrom
Closed
Refactor quick_sort to use in-place sorting for improved space comple…#13837MathewAddala wants to merge 1 commit intoTheAlgorithms:masterfrom
MathewAddala wants to merge 1 commit intoTheAlgorithms:masterfrom
Conversation
…xity This commit refactors the quick_sort function to use an in-place sorting approach instead of creating new lists during the partitioning process. **Changes made:** - Introduced a helper function `_quick_sort(collection, low, high)` that performs the recursive in-place sorting - Implemented `_partition(collection, low, high)` using the Lomuto partition scheme for in-place partitioning - The main `quick_sort(collection)` function now sorts the list in-place and returns it - Removed the list comprehensions that created new `lesser` and `greater` lists - Replaced `collection.pop()` with in-place swapping **Benefits:** - Improved space complexity: O(log n) for the recursion stack instead of O(n) for creating new lists - More memory-efficient, especially for large collections - Maintains the same O(n log n) average time complexity - Still uses random pivot selection for better average-case performance
Multiple Pull Request Detected@MathewAddala, we are extremely excited that you want to submit multiple algorithms in this repository but we have a limit on how many pull request a user can keep open at a time. This is to make sure all maintainers and users focus on a limited number of pull requests at a time to maintain the quality of the code. This pull request is being closed as the user already has an open pull request. Please focus on your previous pull request before opening another one. Thank you for your cooperation. User opened pull requests (including this one): #13837, #13836, #13821, #13818 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the
quick_sortfunction to use an in-place sorting approach, significantly improving space complexity and making it more aligned with standard quicksort implementations.Problem
The current implementation:
lesserandgreater) during partitioning using list comprehensionscollection.pop(pivot_index)to remove the pivotSolution
Refactored to use in-place sorting:
_quick_sort(collection, low, high)that performs recursive in-place sorting_partition(collection, low, high)using the Lomuto partition schemequick_sort(collection)function now sorts the list in-place and returns itBenefits
Technical Details
The implementation uses the Lomuto partition scheme:
ithat tracks the boundary of elements ≤ pivotDescribe your change:
Checklist: