Fix: incorrect output for Binary Search with duplicate elements #13840#13869
Open
sreejabavandla wants to merge 1 commit intoTheAlgorithms:masterfrom
Open
Fix: incorrect output for Binary Search with duplicate elements #13840#13869sreejabavandla wants to merge 1 commit intoTheAlgorithms:masterfrom
sreejabavandla wants to merge 1 commit intoTheAlgorithms:masterfrom
Conversation
…s duplicates (Fixes TheAlgorithms#13840)
ayushHardeniya
approved these changes
Nov 5, 2025
ayushHardeniya
left a comment
There was a problem hiding this comment.
Hi, I’m just passing by and took a quick look at this change.
The updated logic using the answer variable makes sense and correctly handles finding the first occurrence while avoiding unreachable code and redundant returns.
The structure is clear and consistent with standard binary search patterns.
Overall, this looks correct and well-implemented - nice work improving the clarity here. 👍
|
Hi! Thanks for reviewing. Please let me know if any changes are needed. I’ve followed the contributing guidelines and added doctests. Looking forward to feedback! |
anthonijosap
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix incorrect output for Binary Search when list contains duplicates (Fixes #13840)
Describe your change:
Fixed a bug in the binary search algorithm that caused incorrect output when the list contained duplicate elements.
Checklist: