Make package scriptlets more universal#580
Open
iavael wants to merge 1 commit intoTheAssassin:masterfrom
Open
Conversation
TheAssassin
requested changes
Jul 10, 2023
Owner
TheAssassin
left a comment
TheAssassin
left a comment
There was a problem hiding this comment.
Thanks. You have a few good points. Please see my review.
Author
|
@TheAssassin I'll take a deeper look during this week because I have some issues with broadband internet connection now. |
Owner
|
Thanks, I already left some comments. |
iavael
force-pushed
the
fix-scriptlets-1
branch
3 times, most recently
from
9d45e1c to
c37fa87
Compare
Author
|
Ok, I've finished all adjustments. Ready for review. |
Author
|
@TheAssassin in case, if message about adjustments had been finished got lost among notifications, humbly remind you about my PR being ready for review. |
iavael
force-pushed
the
fix-scriptlets-1
branch
from
c37fa87 to
eed5d53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Package scriplets may fail on some system for various reasons like:
So I made command invocation allowed to fail to make package scriptlets more robust in such edge cases.
And also removed unnecessary subshell invocation.