bugfix(view): Fix and improve map border camera constraints behavior to allow see all areas of the map comfortably

[xezon]

Merge with Rebase

• Fixes Camera does not scroll down far enough if centered on higher elevated terrain #1270
• Relates to fix(view): Adjust default camera height to compensate for screen aspect ratio #1711

This change fixes and improves the map border camera constraint behavior to allow see all areas of the map comfortably.

The first commit refactors the code a bit to be more readable.

The second commit does a number of changes to implement the improved camera constraints behavior.

TODO

• Test camera movement
• Replicate in Generals

[Skyaero42]

This is how 3440 x 1440 looks like. This is not playable.

[Mauller]

This is how 3440 x 1440 looks like. This is not playable.

This PR is for fixing camera movement at the edge of the map, my camera height PR does the other stuff.

[Stubbjax]

Units can still hide at the bottom of the screen.

[szeplakib]

@Stubbjax I think we shouldn't test it widescreen until the scale fix is merged

It worked perfectly for me (4:3 1280x1024) :

main:

xezon/fix-camera-constraints:

But I will give it a go with a unit at the bottom of the screen on the same map.

[szeplakib]

Nah, you are right. One can still hide their units in some situations. Also I just figured that you pic is cropped and that is why it is so wide.

[xezon]

I looked into that and issue #1486 is responsible for this. It is related to m_groundLevel. It needs updating, but unfortunately it is more difficult than it seems because of the visual implications.

[Mauller]

I wonder if this factor of 0.95 is causing some of the problems with the lower edge since it is reducing the calculated height with offset.

They don't seem to do this along the X of the screen.

[xezon]

This Pull will be obsolete