tweak(commandline): Skip intro logo with -quickstart and enable -nologo, -noShellAnim in Release builds#2266
Open
xezon wants to merge 1 commit intoTheSuperHackers:mainfrom
Open
Conversation
…go, -noShellAnim in Release builds
Greptile Overview
|
| Filename | Overview |
|---|---|
| GeneralsMD/Code/GameEngine/Source/Common/CommandLine.cpp | Removed RTS_DEBUG restriction from -nologo and -noShellAnim flags, removed unused parseNoSizzle function, and updated -quickstart to skip intro logo in Release builds |
Sequence Diagram
sequenceDiagram
participant User
participant CommandLine
participant parseQuickStart
participant parseNoLogo
participant parseNoShellMap
participant parseNoWindowAnimation
participant GlobalData
User->>CommandLine: Start game with -quickstart flag
CommandLine->>parseQuickStart: Call parseQuickStart()
Note over parseQuickStart: Previously in Release builds:<br/>only called parseNoSizzle()
Note over parseQuickStart: Now in Release builds:<br/>calls parseNoLogo() instead
parseQuickStart->>parseNoLogo: Call parseNoLogo()
parseNoLogo->>GlobalData: m_playIntro = FALSE
parseNoLogo->>GlobalData: m_afterIntro = TRUE
parseNoLogo->>GlobalData: m_playSizzle = FALSE
parseQuickStart->>parseNoShellMap: Call parseNoShellMap()
parseNoShellMap->>GlobalData: m_shellMapOn = FALSE
parseQuickStart->>parseNoWindowAnimation: Call parseNoWindowAnimation()
parseNoWindowAnimation->>GlobalData: m_animateWindows = FALSE
Note over GlobalData: Game starts faster:<br/>- No intro logo<br/>- No sizzle video<br/>- No shell map<br/>- No window animations
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change skips the intro logo with -quickstart and enables -nologo, -noShellAnim in Release builds.
This is good for all players that want to start the game very fast.
TODO