bugfix(audio): Fix particle cannon being inaudible after saveload#2302
Open
stephanmeesters wants to merge 1 commit intoTheSuperHackers:mainfrom
Open
bugfix(audio): Fix particle cannon being inaudible after saveload#2302stephanmeesters wants to merge 1 commit intoTheSuperHackers:mainfrom
stephanmeesters wants to merge 1 commit intoTheSuperHackers:mainfrom
Conversation
Greptile Overview
|
| Filename | Overview |
|---|---|
| GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/ParticleUplinkCannonUpdate.cpp | Restores audio events for particle cannon sounds after save/load by re-registering sound handles in loadPostProcess() when cannon is firing |
Last reviewed commit: 7d22e2e
xezon
reviewed
Feb 13, 2026
| } | ||
| } | ||
|
|
||
| // TheSuperHackers @info stephanmeesters 13/02/2026 |
|
|
||
| // TheSuperHackers @info stephanmeesters 13/02/2026 | ||
| // Fix issue where sound from the particle cannon is not audible after saveload | ||
| if( m_status == STATUS_FIRING || m_status == STATUS_POSTFIRE || m_status == STATUS_PACKING ) |
There was a problem hiding this comment.
Why POSTFIRE and PACKING ?
Can you explain how the statuses relate to the lifetime of the 2 sounds?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue where sound from the particle cannon is not audible after saveload.
Tested with savegames in scenarios
STATUS_FIRING-- actively firingSTATUS_POSTFIRE-- beam is in decaySTATUS_PACKING-- beam has decayed, cleaning upAdds sound handles for
m_firingToIdleSoundwhich is the sound at the particle cannon itself, andm_annihilationSoundwhich is the sound of the beam.Todo