refactor(pathfinder): Remove unused function pathDestination#2308
Open
Caball009 wants to merge 2 commits intoTheSuperHackers:mainfrom
Open
refactor(pathfinder): Remove unused function pathDestination#2308Caball009 wants to merge 2 commits intoTheSuperHackers:mainfrom
Caball009 wants to merge 2 commits intoTheSuperHackers:mainfrom
Conversation
Greptile Overview
|
| Filename | Overview |
|---|---|
| Generals/Code/GameEngine/Include/GameLogic/AIPathfind.h | Removed unused pathDestination function declaration |
| Generals/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp | Removed unused 251-line pathDestination function implementation |
| GeneralsMD/Code/GameEngine/Include/GameLogic/AIPathfind.h | Removed unused pathDestination function declaration |
| GeneralsMD/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp | Removed unused 251-line pathDestination function implementation |
Last reviewed commit: 50dc090
|
I will double check this again, the code appears unused, i believe it was an earlier implementation of what ended up split out into multiple functions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Function
Pathfinder::pathDestinationisn't used now nor in the first usable branch, so this PR removes it.Fortunately, it wasn't used because there would likely be a bug due to the uninitialized coordinate variable here, same as
Pathfinder::tightenPathCallback:GeneralsGameCode/GeneralsMD/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp
Line 8196 in 5d9aa65