Skip to content

fix(preload): add URL protocol filter for openExternal #1314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zerob13 merged 1 commit into from
Feb 14, 2026
Merged

fix(preload): add URL protocol filter for openExternal #1314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions build/entitlements.mac.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@
<true/>
<key>com.apple.security.cs.allow-unsigned-executable-memory</key>
<true/>
<key>com.apple.security.cs.allow-dyld-environment-variables</key>
<true/>
<key>com.apple.security.files.user-selected.read-write</key>
<true/>
<key>com.apple.security.files.user-selected.read-only</key>
Expand Down
15 changes: 15 additions & 0 deletions src/preload/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,17 @@ import {
} from 'electron'
import { exposeElectronAPI } from '@electron-toolkit/preload'

const ALLOWED_PROTOCOLS = ['http:', 'https:', 'mailto:', 'tel:', 'deepchat:']

const isValidExternalUrl = (url: string): boolean => {
try {
const parsed = new URL(url)
return ALLOWED_PROTOCOLS.includes(parsed.protocol.toLowerCase())
} catch {
return false
}
}

// Cache variables
let cachedWindowId: number | undefined = undefined
let cachedWebContentsId: number | undefined = undefined
Expand Down Expand Up @@ -44,6 +55,10 @@ const api = {
return cachedWebContentsId
},
openExternal: (url: string) => {
if (!isValidExternalUrl(url)) {
console.warn('Preload: Blocked openExternal for disallowed URL:', url)
return Promise.reject(new Error('URL protocol not allowed'))
}
return shell.openExternal(url)
},
toRelativePath: (filePath: string, baseDir?: string) => {
Expand Down