Skip to content

feat: enable exhaustive method for list variables #2023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
triceo merged 15 commits into from
Jan 21, 2026
Merged

feat: enable exhaustive method for list variables #2023

triceo merged 15 commits into from
Jan 21, 2026
+2,466 −684

Conversation

@zepfred
Copy link
Contributor

@zepfred zepfred commented Jan 16, 2026

No description provided.

@zepfred zepfred marked this pull request as ready for review January 16, 2026 18:55
@zepfred zepfred requested a review from triceo as a code owner January 16, 2026 18:55
Copilot AI review requested due to automatic review settings January 16, 2026 18:55
Copilot AI reviewed Jan 16, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request enables exhaustive search methods (both Brute Force and Branch & Bound) for list variables in addition to the existing support for basic variables. The changes introduce specialized decider implementations for list variables and mixed models (containing both basic and list variables).

Changes:

  • Introduced ListVariableExhaustiveSearchDecider and MixedVariableExhaustiveSearchDecider to handle list variables and mixed models
  • Refactored ExhaustiveSearchDecider into an abstract base class AbstractExhaustiveSearchDecider with specific implementations (BasicExhaustiveSearchDecider, ListVariableExhaustiveSearchDecider)
  • Updated selector factories and destination selectors to support exhaustive search mode for list variables
  • Added comprehensive test coverage for list variable exhaustive search with various configurations
  • Updated enum implementations to use modern switch expressions

Reviewed changes

Copilot reviewed 24 out of 24 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
AbstractExhaustiveSearchDecider.java New abstract base class extracting common exhaustive search logic
BasicExhaustiveSearchDecider.java New class handling exhaustive search for basic variables
ListVariableExhaustiveSearchDecider.java New class implementing exhaustive search for list variables
MixedVariableExhaustiveSearchDecider.java New class coordinating exhaustive search for mixed models
DefaultExhaustiveSearchPhaseFactory.java Updated to build appropriate deciders based on variable types
DefaultExhaustiveSearchPhase.java Refactored to use new decider architecture
ListChangeMoveSelectorFactory.java Enhanced to support exhaustive search mode
ElementDestinationSelector.java Added exhaustive search support with modified iteration logic
FilteringEntityByValueSelector.java Extended to support exhaustive method with entity replay
CompositeMove.java Made buildMove method public for use in deciders
ExhaustiveSearchNode.java Added generic type parameters to move accessors
Test files Comprehensive test coverage for all exhaustive search configurations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@zepfred zepfred marked this pull request as draft January 17, 2026 00:39
Copilot AI reviewed Jan 17, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@zepfred zepfred requested a review from Copilot January 19, 2026 14:02
Copilot AI reviewed Jan 19, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 26 out of 26 changed files in this pull request and generated 6 comments.

@zepfred zepfred marked this pull request as ready for review January 19, 2026 14:29
Copilot AI review requested due to automatic review settings January 19, 2026 14:29
Copilot AI reviewed Jan 19, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 25 out of 25 changed files in this pull request and generated 3 comments.

Copilot AI review requested due to automatic review settings January 19, 2026 16:19
Copilot AI reviewed Jan 19, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 25 out of 25 changed files in this pull request and generated no new comments.

triceo
triceo reviewed Jan 20, 2026
View reviewed changes
Copy link
Collaborator

@triceo triceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, overall looking good.

@triceo triceo added this to the v1.31.0 milestone Jan 20, 2026
triceo
triceo approved these changes Jan 21, 2026
View reviewed changes
Copy link
Collaborator

@triceo triceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when comments resolved and documentation updated. (If necessary.)

Copilot AI review requested due to automatic review settings January 21, 2026 12:34
Copilot AI reviewed Jan 21, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 33 out of 33 changed files in this pull request and generated 1 comment.

...ain/java/ai/timefold/solver/core/impl/exhaustivesearch/scope/ExhaustiveSearchPhaseScope.java
}

public SortedSet<ExhaustiveSearchNode> getExpandableNodeQueue() {
public SortedSet<ExhaustiveSearchNode<Solution_>> getExpandableNodeQueue() {
Copy link

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getExpandableNodeQueue exposes the internal representation stored in field expandableNodeQueue. The value may be modified after this call to getExpandableNodeQueue.

Copilot uses AI. Check for mistakes.
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 21, 2026

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
89.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@triceo triceo merged commit b156174 into TimefoldAI:main Jan 21, 2026
34 checks passed
@zepfred zepfred deleted the feat/exhaustive branch January 21, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@triceo triceo triceo approved these changes

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.31.0

Development

Successfully merging this pull request may close these issues.

2 participants

@zepfred @triceo