Skip to content

Conversation

@zepfred
Copy link
Contributor

@zepfred zepfred commented Jan 20, 2026

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds the ability for shadow variable supplier methods (updater methods annotated with @ShadowSources) to optionally accept the solution as a parameter. This allows shadow variable calculations to read global solution data when needed.

Changes:

  • Core implementation now supports shadow variable supplier methods with an optional solution parameter
  • Quarkus and Spring Boot integrations updated to handle the new optional parameter
  • Test coverage added for both parameterized and non-parameterized shadow variable suppliers

Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
DeclarativeShadowVariableDescriptor.java Adds logic to lookup supplier methods with optional solution parameter
VariableUpdaterInfo.java Changes calculator from Function to BiFunction to pass solution
ChangedVariableNotifier.java Adds getWorkingSolution() method to provide solution to calculators
SingleDirectionalParentVariableReferenceGraph.java Updates to pass calculator accessor instead of lambda
DefaultShadowVariableSessionFactory.java Updates to pass calculator accessor instead of lambda
TimefoldProcessor.java Updates Quarkus build-time method lookup to handle optional solution parameter
IntegrationTestEntity.java Adds test shadow variables with and without solution parameter
IntegrationTestSolution.java Adds dummy method to support solution parameter test
TestdataStringLengthShadowEntity.java Adds test shadow variables with and without solution parameter
TestdataStringLengthShadowSolution.java Adds dummy method to support solution parameter test
TestdataBasicVarParameter*.java New test domain classes demonstrating the feature
TestdataInvalidDeclarativeParameter*.java New test domain classes for invalid parameter validation
TestdataCountingValue.java Updated signature to accept solution parameter
TestdataConcurrentValue.java Updated signature to accept solution parameter
RootVariableSourceTest.java Adds test for invalid parameter type detection
ShadowVariableUpdateTest.java Adds test for shadow variables with solution parameter

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated 4 comments.

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants