Draft
Conversation
Owner
|
Ah, nice catch. Apologies for that. I reckon we could put the logging in There isn't currently a well-reasoned error handling system (because at the time I wrote this, the errors cognito received weren't exposed, so it didn't seem necessary). If you think it would be useful, we could implement custom error types that are then marshalled to appropriate http codes at the connector boundary. Thinking about it, the specific error you hit could be caught and warned about - like if the logger said "Unable to retrieve users emails- does the app have appropriate permissions?" or something. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without these envs in
config.shthe wrapper fails in web mode:I'll create a draft PR since I have a naive logger there that should be removed and you might want to have an input on how that is implemented for
getUserEmails.