Fix(redshift): add missing db_user parameter for IAM auth#5687
Open
synthpieter wants to merge 3 commits intoTobikoData:mainfrom
Open
Fix(redshift): add missing db_user parameter for IAM auth#5687synthpieter wants to merge 3 commits intoTobikoData:mainfrom
synthpieter wants to merge 3 commits intoTobikoData:mainfrom
Conversation
5c38736 to
f20bb1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SQLMesh's Redshift connection configuration was missing the
db_userparameter, which is required by theredshift_connectorlibrary when using IAM authentication.When enabling iam (iam: True) in the connection config it throws, understandably so, an InterfaceError
However, it was not allowed to add this parameter to the config.
So iam authentication was not really useable.
Solution
Added the
db_userfield to theRedshiftConnectionConfigclass in three places:db_user: t.Optional[str] = Noneto the class"db_user"to the_connection_kwargs_keyspropertyUsage
With this fix, you can now configure Redshift IAM authentication in
config.yaml:Fixes #2146
Disclaimer
This is my first contribution to an open source project ever, so please let me know if this is the right way of doing things :)
I locally give the fix a spin and it seems to fix the problem!