Fix!: Allow init to be walked to track its dependencies#5688
Merged
themisvaltinos merged 3 commits intomainfrom Feb 3, 2026
Merged
Fix!: Allow init to be walked to track its dependencies#5688themisvaltinos merged 3 commits intomainfrom
themisvaltinos merged 3 commits intomainfrom
Conversation
eakmanrq
approved these changes
Feb 2, 2026
georgesittas
approved these changes
Feb 3, 2026
Contributor
|
There may be an edge case where this is breaking, FYI. If Not sure if we can do much about this, just mentioning so that we can defensively mark the PR accordingly. |
Contributor
|
The Windows CI job is failing: Should we update the test? |
4a57092 to
6e524bb
Compare
georgesittas
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue in python model's serialization where class dependencies referenced inside
__init__were not added to the serialised env, for example:This is because in metaprogramming the
build_env()function was skipping all dunder methods including__init__so the dependencies were never added to the serialized environment.