very minor bugfixes #378
Open
very minor bugfixes #378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
missing values arrays no longer pushes values onto the global values() function as keys json/dragon only usage of nested subtractions now correctly uses the subtraction of the channel instead of inverting the addition
✅ Deploy Preview for keen-boyd-1443aa ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling makeNumber() with either no args or an aurgment object with no values key no longer uses the global Object.Prototype.values() function as the values object. (primarily weirdness with invalid json keys cuases this. Or the builtin unused rules.)
Addition and subtraction are entire channel objects with their own addition and subtraction keys, which are supported not by the gui but the backend. However the subtract channel was only being checked on inner channels and instead the addition channel was being inversely applied instead when it was present.