Detect attachment scam regardless of case (jpg vs JPG)#1319
Merged
Conversation
|
marko-radosavljevic
approved these changes
Sep 4, 2025
SquidXTV
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We recently had a case in PROD where someone posted attachment-based scam that went undetected.
The message looked like this:
The reason was that our code compared file extensions case-sensitive. For example only attachments like
1.jpgare detected as image (and hence contribute to the scam check). Attachments like1.JPGbypassed it.Simple fix. Also added a unit test.