Fix GitHub API Jackson conflict by isolating dependency#1333
Fix GitHub API Jackson conflict by isolating dependency#1333modwodmm wants to merge 2 commits intoTogether-Java:developfrom modwodmm:fix/jackson-conflict
Conversation
|
|
Zabuzard
left a comment
Zabuzard
left a comment
There was a problem hiding this comment.
Just to be sure, did you run the code locally on your test server to verify that it works?
Because the problem only showed itself when actually running the code, not during compilation or in unit tests.
| exclude group: 'com.fasterxml.jackson.core' | ||
| exclude group: 'com.fasterxml.jackson.datatype' | ||
| exclude group: 'com.fasterxml.jackson.dataformat' | ||
| exclude group: 'com.fasterxml.jackson.module' |
There was a problem hiding this comment.
please add an indentation (or run spotless)
There was a problem hiding this comment.
Yeah, ran gradlew.bat run and it ran without any error and showed build successful
There was a problem hiding this comment.
please add an indentation (or run spotless)
ran spotless as well
There was a problem hiding this comment.
Yeah, ran gradlew.bat run and it ran without any error and showed build successful
thats not enough though. u need to actually run the bot, connect it to your local test server and for example use the /ping command successfully :)
the compilation worked before already as well.
and u need to check it with the updated dependency as the error doesnt occur beforehand anyways.
There was a problem hiding this comment.
i guess spotless doesnt run on the gradle file then. either case, please add indents, thanks
There was a problem hiding this comment.
You also need to update the jackson dependency to provoke the problematic setup. The current versions never created any problems to begin with. See the ticket description again and the linked jackson update :)
|
Everything done. Changed the version and also tested it. |
3 participants
Fixed the jackson error
Closes #1314