pre-commit: run sonarlintMain task#1368
Merged
christolis merged 1 commit intoTogether-Java:developfrom Jan 2, 2026
Merged
Conversation
Recently thanks to a surge in new contributors, it has been observed
that many of their commits contain code that does not pass Sonarlint
checks. This results in the CI checks failing, and contributors have to
push new commits to address the Sonarlint complaints.
Introduce a new pre-commit hook procedure that also runs Sonarlint right
before a commit gets created, which should exit with a non-zero status
code so that the commit does not get made if it does not pass Sonarlint
checks.
Running Sonarlint checks is a passive task - in other words, it does not
take the initiative of editing the code in order to make it pass the
tests, so it's safe to call the Gradle task by just calling
./gradlew sonarlintMain
Hopefully with this we get less unexpected failures on our CI pipeline
and more motivated contributors.
Signed-off-by: Chris Sdogkos <work@chris-sdogkos.com>
tj-wazei
approved these changes
Jan 2, 2026
Contributor
tj-wazei
left a comment
tj-wazei
left a comment
There was a problem hiding this comment.
Haven't tested but changes look reasonable.
SquidXTV
approved these changes
Jan 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently thanks to a surge in new contributors, it has been observed that many of their commits contain code that does not pass Sonarlint checks. This results in the CI checks failing, and contributors have to push new commits to address the Sonarlint complaints.
Introduce a new pre-commit hook procedure that also runs Sonarlint right before a commit gets created, which should exit with a non-zero status code so that the commit does not get made if it does not pass Sonarlint checks.
Running Sonarlint checks is a passive task - in other words, it does not take the initiative of editing the code in order to make it pass the tests, so it's safe to call the Gradle task by just calling
Hopefully with this we get less unexpected failures on our CI pipeline and more motivated contributors.