-
Notifications
You must be signed in to change notification settings - Fork 9
[ACL-305] Adds support for Verified Payouts #380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a bug on the GET /payouts/$id endpoint whereby a timestamp instead of a date is returned.
That is going to be fixed in future, in the meantime I've added this custom deserializer to let library users just deal with dates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not considering this a breaking change, because:
- library users are not expected to instantiate CreatePayoutResponse objects their own
- the getter for the id field is left untouched
| URI hp2Uri = tlClient.hppLinkBuilder() | ||
| .resourceType(ResourceType.PAYOUT) | ||
| .resourceId(payoutId) | ||
| .resourceToken(resourceToken) | ||
| .returnUri(URI.create(RETURN_URI)) | ||
| .build(); | ||
| assertCanBrowseLink(hp2Uri); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the minute, we don't have a way to trigger execution in an headless fashion in sandbox, hence this test is doing less that what we do elsewhere on acceptance tests
Adds support for Verified payouts.