Add Pehkui integration

- Added Pehkui mod integration to fully hide entities by scaling them down. This is especially beneficial for mobs with emissive layers in 1.20.4 and below, as the previously used vanilla scale attribute doesn't yet exist there (#25)
  - Updated mod metadata to suggest Pehkui
  - Disabled Mecha command validation in the CI workflow upon push due to the now introduced non-vanilla commands

Author: Tschipcraft

.github/workflows/ci.yml

@@ -17,13 +17,13 @@ on:
         description: 'Set to true to skip command validation'
         required: false
         type: boolean
-        default: false
+        default: true
 
 env:
   # Fallback Lower: when Spyglass API is unreachable
   FALLBACK_MC_LOWER: "1.17"
   # Fallback Upper: when Spyglass API and Mojang API are unreachable
-  FALLBACK_MC_UPPER: "1.21.5"
+  FALLBACK_MC_UPPER: "1.21.8"
 
 jobs:
   deploy:
@@ -189,9 +189,9 @@ jobs:
           echo "  NeoForge range: $MACHINE_RANGE_NEOFORGE"
           echo "  Validator version: $CMD_VALIDATOR_MC"
 
-      # Optionally validate commands
+      # Optionally validate commands (disabled by default upon push due to unrecognized Pehkui commands)
       - name: Validate commands
-        if: ${{ github.event.inputs.skip_check != 'true' }}
+        if: ${{ github.event.inputs.skip_check == 'false' }}
         uses: mcbeet/check-commands@v1
         with:
           source: .
@@ -310,6 +310,6 @@ jobs:
             <img alt="❌ Error" src="https://raw.githubusercontent.com/Mqxx/GitHub-Markdown/main/blockquotes/badge/dark-theme/error.svg">
           </picture><br>
 
-          The build v${{ env.TAG }} for mc${{ env.MC_HUMAN_VERSION_RANGE }} failed! Please check the action logs for details.
+          The build **v${{ env.TAG }}** for **Minecraft ${{ env.MC_HUMAN_VERSION_RANGE }}** failed! Please check the action logs for details.
           EOF
           fi

CHANGES.md

@@ -1,7 +1,8 @@
 - **Entities with emissive layers are now properly hidden** (Endermen, Spiders, and Cave Spiders) (closes [#25](https://github.com/Tschipcraft/spawnanimations/issues/25))
+  - For this feature to work in Minecraft 1.20.4 and below, [Pehkui](https://modrinth.com/project/t5W7Jfwy) must be installed. Pehkui can still be installed in newer versions for smoother poof animations
 - Improved performance by refactoring entity activation distance calculations to bundle and cache position data retrieval calls, and updating batch activation logic (the whole data pack is now up to 1ms (~45%ish) faster per tick!)
 - Modified the attack predicate of the secondary dig-up requirements so that it disregards the Y-distance. This allows mobs to, for example, appear at the bottom of pillars, if a player decides to build up during the night
 - Added an activation distance recommendation message when using the vanilla activation mode
 - Fixed possibility for hidden falling mobs to lose their fall distance NBT when appearing
-- Fixed v0 save format not correctly upgrading to v1 from 24w11a to 24w20a (affecting major releases 1.20.5 and 1.20.6)
-- Improved armor save/resolve functions to include the vanishing curse enchantment in the root proxy chest item
+- Fixed v0 save format not correctly upgrading to v1 from 24w11a to 24w20a, affecting major releases 1.20.5 and 1.20.6
+- Improved hide armor and tools option to include the vanishing curse enchantment in the root proxy chest item

META-INF/mods.toml

@@ -44,8 +44,16 @@ features={ java_version = "[17,)" }
     mandatory=false
     versionRange="[1.0,)"
     ordering="NONE"
-    side="BOTH"
+    side="SERVER"
     referralUrl="https://modrinth.com/mod/ofDka6PS/versions?l=forge"
 
+[[dependencies.spawnanimations]]
+    modId="pehkui"
+    mandatory=false
+    versionRange="[3.4.0,)"
+    ordering="NONE"
+    side="BOTH"
+    referralUrl="https://modrinth.com/mod/t5W7Jfwy/versions?l=forge"
+
 [modproperties.spawnanimations]
     catalogueItemIcon="minecraft:zombie_spawn_egg"

META-INF/neoforge.mods.toml

@@ -45,9 +45,18 @@ features={ java_version = "[21,)" }
     type="optional"
     versionRange="[1.0,)"
     ordering="NONE"
-    side="BOTH"
+    side="SERVER"
     referralUrl="https://modrinth.com/mod/ofDka6PS/versions?l=neoforge"
     reason="Compatibility with other mods"
 
+[[dependencies.spawnanimations]]
+    modId="pehkui"
+    type="optional"
+    versionRange="[3.4.0,)"
+    ordering="NONE"
+    side="BOTH"
+    referralUrl="https://modrinth.com/mod/t5W7Jfwy/versions?l=neoforge"
+    reason="Completely hiding entities with an emissive layer"
+
 [modproperties.spawnanimations]
     catalogueItemIcon="minecraft:zombie_spawn_egg"

data/spawnanimations/function/internal/entity/ehs/hide.mcfunction

@@ -7,3 +7,6 @@ execute store result score @s ts.sa.e.nbt.Sil run data get entity @s Silent
 execute if score @s ts.sa.e.nbt.Sil matches 0 run data merge entity @s {Silent:1b}
 tag @s add ts.sa.to_hide
 effect give @s invisibility 10 0 true
+
+# Pehkui integration (overlay_pre_49)
+function spawnanimations:internal/entity/ehs/pehkui/hide

data/spawnanimations/function/internal/entity/ehs/hide_exec.mcfunction

@@ -10,4 +10,4 @@ execute if score $hide_armor ts.sa.settings matches 1..2 as @s[type=#spawnanimat
 
 # Entity specific
 execute if entity @s[type=minecraft:creeper] run function spawnanimations:internal/entity/ehs/entity_specific/creeper/hide
-execute if entity @s[type=#spawnanimations:has_emissive_layer] run function spawnanimations:internal/entity/ehs/entity_specific/emissive_layer/hide
+execute if entity @s[type=#spawnanimations:has_emissive_layer,tag=!ts.sa.ehs.pehkui.shrunk] run function spawnanimations:internal/entity/ehs/entity_specific/emissive_layer/hide

data/spawnanimations/function/internal/entity/ehs/unhide.mcfunction

@@ -10,5 +10,6 @@ execute as @s[tag=ts.sa.ehs.saved] run function spawnanimations:internal/entity/
 # Entity specific
 execute if entity @s[type=minecraft:creeper] run function spawnanimations:internal/entity/ehs/entity_specific/creeper/unhide
 execute as @s[tag=ts.sa.ehs.shrunk] run function spawnanimations:internal/entity/ehs/entity_specific/emissive_layer/unhide
+execute as @s[tag=ts.sa.ehs.pehkui.shrunk] run function spawnanimations:internal/entity/ehs/pehkui/unhide
 
 tag @s remove ts.sa.hidden

data/spawnanimations/functions/internal/entity/ehs/hide.mcfunction

@@ -7,3 +7,6 @@ execute store result score @s ts.sa.e.nbt.Sil run data get entity @s Silent
 execute if score @s ts.sa.e.nbt.Sil matches 0 run data merge entity @s {Silent:1b}
 tag @s add ts.sa.to_hide
 effect give @s invisibility 10 0 true
+
+# Pehkui integration
+function spawnanimations:internal/entity/ehs/pehkui/hide

data/spawnanimations/functions/internal/entity/ehs/hide_exec.mcfunction

@@ -10,4 +10,4 @@ execute if score $hide_armor ts.sa.settings matches 1..2 as @s[type=#spawnanimat
 
 # Entity specific
 execute if entity @s[type=minecraft:creeper] run function spawnanimations:internal/entity/ehs/entity_specific/creeper/hide
-execute if entity @s[type=#spawnanimations:has_emissive_layer] run function spawnanimations:internal/entity/ehs/entity_specific/emissive_layer/hide
+execute if entity @s[type=#spawnanimations:has_emissive_layer,tag=!ts.sa.ehs.pehkui.shrunk] run function spawnanimations:internal/entity/ehs/entity_specific/emissive_layer/hide

data/spawnanimations/functions/internal/entity/ehs/pehkui/hide.mcfunction

@@ -0,0 +1,10 @@
+##by Tschipcraft
+# Shrinks entities with an emissive layer to lower scale
+
+scale delay set pehkui:model_width 0 @s
+scale delay set pehkui:model_height 0 @s
+
+scale set pehkui:model_width 0.0001 @s
+scale set pehkui:model_height 0.0001 @s
+
+tag @s add ts.sa.ehs.pehkui.shrunk