Skip to content

Fix CORS preflight Access-Control-Allow-Headers when wildcard configured #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tuntii merged 2 commits into from
Jan 18, 2026
Merged

Fix CORS preflight Access-Control-Allow-Headers when wildcard configured #37

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9424fac
Fix CORS preflight allow-headers for wildcard
Tuntii Jan 17, 2026
d34d394
Update crates/rustapi-extras/src/cors/mod.rs
Tuntii Jan 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions crates/rustapi-extras/src/cors/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,16 @@ impl MiddlewareLayer for CorsLayer {
) -> Pin<Box<dyn Future<Output = Response> + Send + 'static>> {
let origins = self.origins.clone();
let methods = self.methods_header_value();
let headers = self.headers_header_value();
let allow_headers = if self.headers.len() == 1 && self.headers.first().map(|value| value == "*").unwrap_or(false) {
req.headers()
.get(header::ACCESS_CONTROL_REQUEST_HEADERS)
.and_then(|value| value.to_str().ok())
.filter(|value| !value.trim().is_empty())
.map(str::to_string)
.unwrap_or_else(|| "*".to_string())
} else {
self.headers_header_value()
};
let credentials = self.credentials;
let max_age = self.max_age;
let is_any_origin = matches!(origins, AllowedOrigins::Any);
Expand Down Expand Up @@ -256,7 +265,7 @@ impl MiddlewareLayer for CorsLayer {
// Set Allow-Headers
headers_mut.insert(
header::ACCESS_CONTROL_ALLOW_HEADERS,
headers.parse().unwrap(),
allow_headers.parse().unwrap(),
);

// Set Allow-Credentials
Expand Down
Loading