Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions packages/main/src/components/ObjectPage/types/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,17 +32,18 @@ export interface ObjectPagePropTypes extends Omit<CommonProps, 'placeholder'> {
/**
* Defines the upper, always static, title section of the `ObjectPage`.
*
* __Note:__ Although this prop accepts all HTML Elements, it is strongly recommended that you only use `ObjectPageTitle` in order to preserve the intended design.
*
* __Note:__ When the `ObjectPageTitle` is rendered inside a custom component, it's essential to pass through all props, as otherwise the component won't function as intended!
* __Note:__
* - Use the `ObjectPageTitle` component in order to preserve the intended design.
* - When the `ObjectPageTitle` is rendered inside a custom component, it's essential to pass through all props, as otherwise the component won't function as intended!
*/
titleArea?: ReactElement<ObjectPageTitlePropTypes>;
/**
* Defines the `ObjectPageHeader` section of the `ObjectPage`.
*
* __Note:__ Although this prop accepts all HTML Elements, it is strongly recommended that you only use `ObjectPageHeader` in order to preserve the intended design.
*
* __Note:__ When the `ObjectPageHeader` is rendered inside a custom component, it's essential to pass through all props, as otherwise the component won't function as intended!
* __Note:__
* - Use the `ObjectPageHeader` component in order to preserve the intended design.
* - The `ObjectPageHeader` is essentially the `DynamicPageHeader` recommended by SAP Design. It was renamed in v2 to avoid conflicts with the `DynamicPageHeader` from `@ui5/webcomponents`.
* - When the `ObjectPageHeader` is rendered inside a custom component, it's essential to pass through all props, as otherwise the component won't function as intended!
*/
headerArea?: ReactElement<ObjectPageHeaderPropTypes>;
/**
Expand Down
4 changes: 3 additions & 1 deletion packages/main/src/components/ObjectPageHeader/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@ export interface InternalProps extends ObjectPageHeaderPropTypes {
/**
* The `ObjectPageHeader` component is used to serve as header section of the `ObjectPage`. It can hold any layout control and has two states - expanded and collapsed.
*
* __Note:__ When used inside a custom component, it's essential to pass through all props, as otherwise the component won't function as intended!
* __Note:__
* - When used inside a custom component, it's essential to pass through all props, as otherwise the component won't function as intended!
* - The `ObjectPageHeader` is essentially the `DynamicPageHeader` recommended by SAP Design. It was renamed in v2 to avoid conflicts with the `DynamicPageHeader` from `@ui5/webcomponents`.
*/
const ObjectPageHeader = forwardRef<HTMLDivElement, InternalProps>((props, ref) => {
const { children, headerPinned, topHeaderHeight, className, style, ...rest } = props;
Expand Down
Loading