Skip to content

fix(ObjectPage): disable titleArea interaction if no headerArea #8121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lukas742 merged 1 commit into from
Jan 21, 2026
Merged

fix(ObjectPage): disable titleArea interaction if no headerArea #8121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/main/src/components/ObjectPage/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ const ObjectPage = forwardRef<ObjectPageDomRef, ObjectPagePropTypes>((props, ref
selectedSectionId ?? firstSectionId,
);
const [tabSelectId, setTabSelectId] = useState<null | string>(null);
const titleAreaInteractive = headerArea && !preserveHeaderStateOnClick;

const isProgrammaticallyScrolled = useRef(false);
const [componentRef, objectPageRef] = useSyncRef(ref);
Expand Down Expand Up @@ -512,7 +513,7 @@ const ObjectPage = forwardRef<ObjectPageDomRef, ObjectPagePropTypes>((props, ref

const onTitleClick = (e) => {
e.stopPropagation();
if (!preserveHeaderStateOnClick) {
if (titleAreaInteractive) {
onToggleHeaderContentVisibility(enrichEventWithDetails(e, { visible: headerCollapsed }));
}
};
Expand Down Expand Up @@ -667,7 +668,7 @@ const ObjectPage = forwardRef<ObjectPageDomRef, ObjectPagePropTypes>((props, ref
data-component-name="ObjectPageTopHeader"
ref={topHeaderRef}
role={accessibilityAttributes?.objectPageTopHeader?.role}
data-not-clickable={!!preserveHeaderStateOnClick}
data-not-clickable={!titleAreaInteractive}
aria-roledescription={
accessibilityAttributes?.objectPageTopHeader?.ariaRoledescription ?? 'Object Page header'
}
Expand All @@ -682,7 +683,7 @@ const ObjectPage = forwardRef<ObjectPageDomRef, ObjectPagePropTypes>((props, ref
cloneElement(titleArea as ReactElement<ObjectPageTitlePropsWithDataAttributes>, {
className: clsx(titleArea?.props?.className),
onToggleHeaderContentVisibility: onTitleClick,
'data-not-clickable': !!preserveHeaderStateOnClick,
'data-not-clickable': !titleAreaInteractive,
'data-header-content-visible': headerArea && headerCollapsed !== true,
_snappedAvatar: (
<CollapsedAvatar
Expand Down
Loading