fix(OpenUI5Support): override default [popover] padding#13019
Open
s-todorova wants to merge 1 commit intomainfrom
Open
fix(OpenUI5Support): override default [popover] padding#13019s-todorova wants to merge 1 commit intomainfrom
s-todorova wants to merge 1 commit intomainfrom
Conversation
SNOW: DINC0776938
Collaborator
|
🚀 Deployed on https://pr-13019--ui5-webcomponents-preview.netlify.app |
ilhan007
reviewed
Feb 4, 2026
| border: none; | ||
| overflow: visible; | ||
| margin: 0; | ||
| padding: 0; |
Contributor
There was a problem hiding this comment.
This will clear the left/right paddings (reported in the related issue), but there is a chance to also overwrite/reset the sap.m.Dialog's top and bottom paddings. Did you verify this? If yes - then it's good to go.
Contributor
Author
There was a problem hiding this comment.
Tested on local page for OpenUi5Support - seemed ok.
Contributor
There was a problem hiding this comment.
I imagine verifying it on the reproducible environment (because the release + consumption cycle is a long process) but this is up to you - I am fine with the change itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SNOW: DINC0776938