refactor(RuntimeFactory): refactor runtime and factory #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshaylive
force-pushed
the
akshaya/alternative
branch
2 times, most recently
from
bb15df6 to
27462cb
Compare
akshaylive
changed the title
akshaylive
force-pushed
the
akshaya/alternative
branch
2 times, most recently
from
0889e50 to
1ed7a61
Compare
cristipufu
reviewed
Nov 8, 2025
| execution_result = UiPathRuntimeResult() | ||
| if self.execution_id: | ||
| with self.trace_manager.start_execution_span( | ||
| self.root_span, execution_id=self.execution_id |
Member
There was a problem hiding this comment.
we need to be able to populate the parent span with extra attributes (eval item id etc)
cristipufu
reviewed
Nov 8, 2025
cristipufu
reviewed
Nov 8, 2025
cristipufu
reviewed
Nov 8, 2025
cristipufu
force-pushed
the
akshaya/alternative
branch
4 times, most recently
from
e3bd9d9 to
9995e68
Compare
This is done in order to follow single responsibility principles (SRP).
cristipufu
force-pushed
the
akshaya/alternative
branch
6 times, most recently
from
0c99437 to
20c2c37
Compare
cristipufu
force-pushed
the
akshaya/alternative
branch
from
20c2c37 to
c662cbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done in order to follow single responsibility principles.