Performance Optimization: Implement conditional script and style loading#59
Open
marcusquinn wants to merge 1 commit intoUltimate-Multisite:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For consideration, or feedback:
Performance Optimization: Conditional Asset Loading
Description
This PR implements conditional loading of scripts and styles to improve performance by reducing unnecessary asset loading. The optimization focuses on loading scripts and styles only when they are needed, rather than on every admin page.
Changes Made
is_wp_ultimo_list_page()- For pages that need list table scriptsis_wp_ultimo_vue_page()- For pages that need Vue.jsis_wp_ultimo_modal_page()- For pages that need modal functionalityis_wp_ultimo_flags_page()- For pages that need country flagsenqueue_default_admin_styles()andenqueue_default_admin_scripts()to conditionally load assetswu_get_asset()functionBenefits
Testing
Note on Previous PR
This PR is a focused version of the performance optimizations from PR #39. Based on feedback from @superdav42, we've removed the database query caching portion as BerlinDB already handles that efficiently. This PR focuses solely on the conditional asset loading improvements.