-
Notifications
You must be signed in to change notification settings - Fork 18
update python versions and dependencies in pyproject.toml #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The build logs indicate that mpl 3.9 is not compatible with 3.8. It states that the ABI for python 3.8 is not compatible with mpl 3.9. To be precise this is the reason raised: This would mean that UltraPlot also drop support for python 3.8 -- although in practice it would probable work fine. |
|
Made a wiki entry proposing support process moving forward. Open to hearing feedback from the community on this; whether adopting an N-2 feedback model would work for the users etc. |
|
I think it would be best to release a minor version update (v1.0.1) and from the next major version (v1.1) drop support for python <3.11. |
|
You would drop py 3.10 already? Arguments for keeping py 3.10:
|
|
You are absolutely right. I have no qualms keeping it in until it's end of life. |
|
Ok, In any case, it seems to work, PR is fine to merge from my side |
|
This way it directly grabs the supported version from toml and we can set it an forget it 😬 |
|
I am merging this with devel. After locally testing the open PRs it all looks good for now. |
57e2cef to
ecd38be
Compare
fixes #19
is it correct that ultraplot is python version >= 3.9?
if so, the previous 'importlib-metadata; python_version>"3.8"', can be removed since python 3.8 is no longer supported.
also updated classifier and requires-python