Skip to content

[pull] master from DefinitelyTyped:master #1559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 2 commits into from
Jan 10, 2026
Merged

[pull] master from DefinitelyTyped:master #1559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ef8c48
🤖 Merge PR #74244 Lodash intersectionWith comparator has a second arg…
Glandos Jan 10, 2026
94b552b
🤖 Merge PR #74270 [chrome] documentId is optional in webRequest names…
erwanjugand Jan 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion types/chrome/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13162,7 +13162,7 @@ declare namespace chrome {
* The UUID of the document making the request.
* @since Chrome 106
*/
documentId: string;
documentId?: string;
/**
* The lifecycle the document is in.
* @since Chrome 106
Expand Down
16 changes: 8 additions & 8 deletions types/chrome/test/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6910,7 +6910,7 @@ function testWebRequest() {
checkWebRequestEvent(chrome.webRequest.onAuthRequired, (details, asyncCallback) => {
details.challenger.host; // $ExpectType string
details.challenger.port; // $ExpectType number
details.documentId; // $ExpectType string
details.documentId; // $ExpectType string | undefined
details.documentLifecycle; // $ExpectType DocumentLifecycle
details.frameId; // $ExpectType number
details.frameType; // $ExpectType FrameType
Expand All @@ -6937,7 +6937,7 @@ function testWebRequest() {
}, ["responseHeaders", "blocking", "asyncBlocking", "extraHeaders"]);

checkWebRequestEvent(chrome.webRequest.onBeforeRedirect, (details) => {
details.documentId; // $ExpectType string
details.documentId; // $ExpectType string | undefined
details.documentLifecycle; // $ExpectType DocumentLifecycle
details.frameId; // $ExpectType number
details.frameType; // $ExpectType FrameType
Expand Down Expand Up @@ -6985,7 +6985,7 @@ function testWebRequest() {
checkWebRequestEvent(
chrome.webRequest.onBeforeSendHeaders,
(details) => {
details.documentId; // $ExpectType string
details.documentId; // $ExpectType string | undefined
details.documentLifecycle; // $ExpectType DocumentLifecycle
details.frameId; // $ExpectType number
details.frameType; // $ExpectType FrameType
Expand All @@ -7008,7 +7008,7 @@ function testWebRequest() {
);

checkWebRequestEvent(chrome.webRequest.onCompleted, (details) => {
details.documentId; // $ExpectType string
details.documentId; // $ExpectType string | undefined
details.documentLifecycle; // $ExpectType DocumentLifecycle
details.frameId; // $ExpectType number
details.frameType; // $ExpectType FrameType
Expand All @@ -7031,7 +7031,7 @@ function testWebRequest() {
}, ["responseHeaders", "extraHeaders"]);

checkWebRequestEvent(chrome.webRequest.onErrorOccurred, (details) => {
details.documentId; // $ExpectType string
details.documentId; // $ExpectType string | undefined
details.documentLifecycle; // $ExpectType DocumentLifecycle
details.error; // $ExpectType string
details.frameId; // $ExpectType number
Expand All @@ -7050,7 +7050,7 @@ function testWebRequest() {
}, ["extraHeaders"]);

checkWebRequestEvent(chrome.webRequest.onHeadersReceived, (details) => {
details.documentId; // $ExpectType string
details.documentId; // $ExpectType string | undefined
details.documentLifecycle; // $ExpectType DocumentLifecycle
details.frameId; // $ExpectType number
details.frameType; // $ExpectType FrameType
Expand All @@ -7073,7 +7073,7 @@ function testWebRequest() {
}, ["blocking", "responseHeaders", "extraHeaders"]);

checkWebRequestEvent(chrome.webRequest.onResponseStarted, (details) => {
details.documentId; // $ExpectType string
details.documentId; // $ExpectType string | undefined
details.documentLifecycle; // $ExpectType DocumentLifecycle
details.frameId; // $ExpectType number
details.frameType; // $ExpectType FrameType
Expand All @@ -7096,7 +7096,7 @@ function testWebRequest() {
}, ["responseHeaders", "extraHeaders"]);

checkWebRequestEvent(chrome.webRequest.onSendHeaders, (details) => {
details.documentId; // $ExpectType string
details.documentId; // $ExpectType string | undefined
details.documentLifecycle; // $ExpectType DocumentLifecycle
details.frameId; // $ExpectType number
details.frameType; // $ExpectType FrameType
Expand Down
6 changes: 3 additions & 3 deletions types/lodash/common/array.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -780,7 +780,7 @@ declare module "../index" {
/**
* @see _.intersectionWith
*/
intersectionWith<T>(array?: List<T> | null, ...values: Array<List<T> | Comparator2<T, never>>): T[];
intersectionWith<T>(array?: List<T> | null, ...values: Array<List<T> | Comparator<T>>): T[];
}
interface Collection<T> {
/**
Expand All @@ -790,7 +790,7 @@ declare module "../index" {
/**
* @see _.intersectionWith
*/
intersectionWith(...values: Array<List<unknown> | Comparator2<T, never>>): Collection<T>;
intersectionWith(...values: Array<List<unknown> | Comparator<T>>): Collection<T>;
}
interface CollectionChain<T> {
/**
Expand All @@ -800,7 +800,7 @@ declare module "../index" {
/**
* @see _.intersectionWith
*/
intersectionWith(...values: Array<List<unknown> | Comparator2<T, never>>): CollectionChain<T>;
intersectionWith(...values: Array<List<unknown> | Comparator<T>>): CollectionChain<T>;
}
interface LoDashStatic {
/**
Expand Down
2 changes: 1 addition & 1 deletion types/lodash/lodash-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -760,7 +760,7 @@ _.chain([1, 2, 3, 4]).unshift(5, 6); // $ExpectType CollectionChain<number>
// $ExpectType AbcObject[]
_.intersectionWith(...[list, list], (a, b) => {
a; // $ExpectType AbcObject
b; // $ExpectType never || AbcObject
b; // $ExpectType AbcObject
return true;
});

Expand Down