Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frontend/src/ts/elements/input-validation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {
} from "@monkeytype/schemas/configs";
import Config, { setConfig } from "../config";
import * as Notifications from "../elements/notifications";
import { ElementWithUtils } from "../utils/dom";
import { DomUtilsEvent, ElementWithUtils } from "../utils/dom";

export type ValidationResult = {
status: "checking" | "success" | "failed" | "warning";
Expand Down Expand Up @@ -60,7 +60,7 @@ export function createInputEventHandler<T>(
callback: (result: ValidationResult) => void,
validation: Validation<T>,
inputValueConvert?: (val: string) => T,
): (e: Event) => Promise<void> {
): (e: DomUtilsEvent) => Promise<void> {
let callIsValid =
validation.isValid !== undefined
? debounceIfNeeded(
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/ts/utils/caret.ts
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ export class Caret {
if (options.letterIndex >= letters.length) {
side = "afterLetter";

if (Config.blindMode) {
if (Config.blindMode || Config.hideExtraLetters) {
options.letterIndex = wordText?.length - 1;
} else {
options.letterIndex = letters.length - 1;
Expand Down
35 changes: 22 additions & 13 deletions frontend/src/ts/utils/dom.ts
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,12 @@ type ElementWithValue =
| HTMLTextAreaElement
| HTMLSelectElement;

export type DomUtilsEvent<T extends Event = Event> = Omit<T, "currentTarget">;

type DomUtilsEventListenerOrEventListenerObject =
| { (evt: DomUtilsEvent): void }
| { handleEvent(object: DomUtilsEvent): void };

export class ElementWithUtils<T extends HTMLElement = HTMLElement> {
/**
* The native dom element
Expand Down Expand Up @@ -238,19 +244,19 @@ export class ElementWithUtils<T extends HTMLElement = HTMLElement> {
*/
on<K extends keyof HTMLElementEventMap>(
event: K,
handler: (this: T, ev: HTMLElementEventMap[K]) => void,
handler: (this: T, ev: DomUtilsEvent<HTMLElementEventMap[K]>) => void,
): this;
on(event: string, handler: EventListenerOrEventListenerObject): this;
on(event: string, handler: DomUtilsEventListenerOrEventListenerObject): this;
on(
event: keyof HTMLElementEventMap | string,
handler:
| EventListenerOrEventListenerObject
| ((this: T, ev: Event) => void),
| DomUtilsEventListenerOrEventListenerObject
| ((this: T, ev: DomUtilsEvent) => void),
): this {
// this type was some AI magic but if it works it works
this.native.addEventListener(
event,
handler as EventListenerOrEventListenerObject,
handler as DomUtilsEventListenerOrEventListenerObject,
);
return this;
}
Expand All @@ -262,19 +268,22 @@ export class ElementWithUtils<T extends HTMLElement = HTMLElement> {
onChild<K extends keyof HTMLElementEventMap>(
event: K,
query: string,
handler: (this: HTMLElement, ev: HTMLElementEventMap[K]) => void,
handler: (
this: HTMLElement,
ev: DomUtilsEvent<HTMLElementEventMap[K]>,
) => void,
): this;
onChild(
event: string,
query: string,
handler: EventListenerOrEventListenerObject,
handler: DomUtilsEventListenerOrEventListenerObject,
): this;
onChild(
event: keyof HTMLElementEventMap | string,
query: string,
handler:
| EventListenerOrEventListenerObject
| ((this: HTMLElement, ev: Event) => void),
| DomUtilsEventListenerOrEventListenerObject
| ((this: HTMLElement, ev: DomUtilsEvent) => void),
): this {
// this type was some AI magic but if it works it works
this.native.addEventListener(event, (e) => {
Expand Down Expand Up @@ -671,14 +680,14 @@ export class ElementsWithUtils<
*/
on<K extends keyof HTMLElementEventMap>(
event: K,
handler: (this: T, ev: HTMLElementEventMap[K]) => void,
handler: (this: T, ev: DomUtilsEvent<HTMLElementEventMap[K]>) => void,
): this;
on(event: string, handler: EventListenerOrEventListenerObject): this;
on(event: string, handler: DomUtilsEventListenerOrEventListenerObject): this;
on(
event: keyof HTMLElementEventMap | string,
handler:
| EventListenerOrEventListenerObject
| ((this: T, ev: Event) => void),
| DomUtilsEventListenerOrEventListenerObject
| ((this: T, ev: DomUtilsEvent) => void),
): this {
for (const item of this) {
item.on(event, handler);
Expand Down
Loading