forked from monkeytypegame/monkeytype
-
Notifications
You must be signed in to change notification settings - Fork 0
[pull] master from monkeytypegame:master #757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Description Baerer -> Bearer
### Description I removed the ` ` as it is explicity requesting a whitespace, eventhough the formatting is already naturally setting a whitespace. This lead to a double whitespace: <img width="673" height="33" alt="image" src="https://github.com/user-attachments/assets/84b4243f-a867-4cf9-a177-f0dfb5b35016" /> <!-- label(docs): Fix double whitespace in privacy-policy.html (@ChopChopp) -->
## Description Updated Swiss German language files with improved word selection, corrections, and Swiss-specific vocabulary enhancements. ## Changes - Modified `swiss_german.json` (200 words) - Modified `swiss_german_1k.json` (1000 words) - Modified `swiss_german_2k.json` (2000 words) ## Type of Change - [ ] New feature - [x] Improvement to existing feature - [ ] Bug fix - [ ] Documentation update ## Specific Improvements Made ### Swiss German Vocabulary Additions - Added authentic Swiss German words like: `Velo` (bicycle), `Spital` (hospital), `parkieren` (to park) - Included Swiss-specific food terms: `Znüni`, `Zvieri`, `Rüebli`, `Glace` - Added Swiss city names with proper spelling: `Zürich`, `Bern`, `Basel`, `Luzern`, etc. ### Spelling Corrections (Swiss vs. German Standard) - Replaced German `ß` with Swiss `ss` throughout all files - Examples: `groß` → `gross`, `Straße` → `Strasse`, `heißt` → `heisst` - Ensured consistency with Swiss High German orthography (BCP47: de-CH) ### Word Selection Improvements - Removed duplicate or non-Swiss vocabulary - Prioritized commonly used Swiss German words - Maintained appropriate difficulty progression across 200/1k/2k word lists ## Regional Dialect Considerations - All changes follow **Swiss High German** (Schweizer Hochdeutsch) standards - BCP47 language code: `de-CH` is correctly set - Vocabulary reflects Swiss usage, not German or Austrian variants - Special attention to Swiss-German loanwords and regionalisms ## Testing Performed - [x] Verified JSON syntax is valid (no trailing commas) - [x] Confirmed word counts match file names (200/1000/2000) - [x] Tested that no expletive words are included - [x] Checked language appears correctly in `_list` and `_groups` files - [x] Manual typing test performed to verify readability ## Word Count Verification - `swiss_german.json`: 200 words ✓ - `swiss_german_1k.json`: 1000 words ✓ - `swiss_german_2k.json`: 2000 words ✓ ## Source Attribution Words sourced from: - https://1000mostcommonwords.com/1000-most-common-swiss-german-words/ - https://de.wiktionary.org (for 2k list) ## Additional Context These changes improve the authenticity and usability of Swiss German language support in Monkeytype, making it more accurate for Swiss users and learners of Swiss High German. ## Screenshots _N/A - No visual changes to UI_
…7335) ### Description In polyglot mode, some words are generated incorrectly because the lowercasing of randomWord does not take the actual language of the word into account. This change modifies the lowercasing check to base the comparison on the language provided by PolyglotWordset. Co-authored-by: Jack <jack@monkeytype.com>
…onabcd123) (#7337) ### Description Update tag pbs after adding or removing a tag from some test result. Fixes the following bug: - Create a tag - Click on the tag to mark it as active to apply it automatically for the following tests - Complete a test - Remove the tag from the test - Complete another test, while being slower than the previous test - Notice that the tag pb is still the one for the old test, even though it doesn't have the tag anymore --------- Co-authored-by: Jack <jack@monkeytype.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )