Merged
Conversation
Contributor
CaelmBleidd
approved these changes
Sep 3, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR enhances enum support in the TypeScript ETS (Electronic TypeScript) analysis framework by adding comprehensive test cases and refactoring the EtsEnumValueType model.
- Added extensive enum test coverage including basic enums, string enums, mixed enums, const enums, and edge cases
- Updated the
EtsEnumValueTypemodel to use class signature instead of field signature for better type representation - Updated test cases to reflect the new enum structure and validate proper categorization
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| enum.ts | Replaced simple Animal enum with comprehensive enum examples covering all TypeScript enum patterns |
| enum-modules.ts | New test file demonstrating enum export/import patterns and module usage scenarios |
| enum-edge-cases.ts | New test file covering edge cases like empty enums, special characters, and complex access patterns |
| EtsFromJsonTest.kt | Updated test expectations to match new BasicEnum structure with three fields instead of two |
| EnumTest.kt | New comprehensive test suite validating enum parsing, categorization, and usage patterns |
| Type.kt | Refactored EtsEnumValueType to use ClassSignature and optional name field for better type naming |
| Types.kt | Updated DTO structure to align with new EtsEnumValueType model |
| Convert.kt | Updated conversion logic to handle new EnumValueTypeDto structure |
| ci.yml | Updated branch reference for arkanalyzer dependency |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.