Draft
Conversation
- Move InputSystem/* to Runtime/ (preserving history) - Move InputSystem/Editor to Editor/ (preserving history) - Add meta files for new folder structure - Follows Unity package layout conventions - All file history preserved via git mv
Also exposes the required internals between assemblies.
This is done to avoid calling into Edito specific code. Instead, it will be called if Editor code has registered a callback.
Due to refactoring, a lot of paths still contained the InputSystem folder path that no longer exists. We only have Editor and Runtime folders.
Some files were moved to other folders, after merging conflicts arise but since they showed as removed changes didn't land on the moved files. This commit is fixing this
… event buffer init; checked casts; null when empty
…utActionAsset expression body
… SystemBackendsEnabled
…tionsOldBackend()
…elnputDeviceBasedOnSteam|GAFile Uncommenting code from InputSystem.cs -> s_RemoteConnection fixes 2 playmode tests
List of tests: 1. Editor_DomainReload_InputSystemInitializationCausesDevicesToBeRecreated 2. Editor_DomainReload_PreservesEnabledState 3. Editor_DomainReload_PreservesUsagesOnDevices 4. Editor_DomainReload_RetainsUnsupportedDevices
…lay mode tests 1. Editor_InitializeInEditor_EnablesProjectWideActions 2. Editor_InputEventsOccurringWhileGoingIntoPlayMode_AreDiscarded 3. Editor_LeavingPlayMode_DestroysAllActionStates 4. Editor_LeavingPlayMode_DiscardsInputActionAssetChanges 5. Editor_LeavingPlayMode_RemovesAllInputUsersAndStopsListeningForUnpairedDeviceActivity
… test Delete the two LogAssert.Expect lines. Were we intentionally validating that duplicate singleton construction still produces errors? If so, I will revert this commit
This reverts commit a225669.
Fixing compilation errors for CI tests in InputSystem-StandaloneIl2CppPerformanceTests - 6000.0 - MacOS job
…stRuntime handler setup
Remote_CanDisableUnityRemoteSupport test fixed
Instable test fix solution: EditorInputControlLayoutCache.Refresh() could return early without holding a cache reference, causing "Must hold an instance reference" asserts after InputSystem.SaveAndReset() in tests. Now, Refresh() ensures a cache ref is held even on the early-return path.
…ble(): ensure CustomDevice restored from saved state Fix domain reload in InputSystem tests: ensure CustomDevice restored from saved state - SimulateDomainReload() now calls SimulateDomainReloadRecoveryFromSerializedState() - Clears InputSystem.devices and restores saved device states from serialized InputSystemObject - Ensures Editor_DomainReload_CustomDevicesAreRestoredAsLayoutsBecomeAvailable test passes
…meAvailable(): ensure CustomDevice restored from saved state" This reverts commit 24a6469.
…_SYSTEM_ENABLE_UI Fix compilation errors in VirtualMouseInputEditor.cs with UNITY_INPUT_SYSTEM_ENABLE_UI so it only compiles when UI runtime types are present
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please fill this section with a description what the pull request is trying to address and what changes were made.
Testing status & QA
Please describe the testing already done by you and what testing you request/recommend QA to execute. If you used or created any testing project please link them here too for QA.
Overall Product Risks
Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.
Comments to reviewers
Please describe any additional information such as what to focus on, or historical info for the reviewers.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.