enable ros2 launch endpoint.py#164
Open
kimushun1101 wants to merge 2 commits intoUnity-Technologies:dev-ros2from
Open
enable ros2 launch endpoint.py#164kimushun1101 wants to merge 2 commits intoUnity-Technologies:dev-ros2from
kimushun1101 wants to merge 2 commits intoUnity-Technologies:dev-ros2from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
A Launch file could not be executed by
ros2 launchunless the file name contained the word "launch".It is recommended to change the file name to include "_launch" for the sake of readability.
Useful links (GitHub issues, JIRA tickets, forum threads, etc.)
https://docs.ros.org/en/humble/Tutorials/Intermediate/Launch/Creating-Launch-Files.html
Types of change(s)
Testing and Verification
colcon buildandsource install/local_setup.bash, thenros2 launch ros_tcp_endpoint endpoint_launch.pyTest Configuration:
Checklist
devbranchdevbranchOther comments
A solution to #146 is also recommended.