-
Notifications
You must be signed in to change notification settings - Fork 124
Converted remaining references from instanceID to entityID. #1096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr |
PR Code Suggestions ✨No code suggestions found for the PR. |
glabute
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #1096 +/- ##
==========================================
- Coverage 17.34% 17.32% -0.02%
==========================================
Files 209 209
Lines 23692 23699 +7
==========================================
- Hits 4110 4107 -3
- Misses 19582 19592 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Purpose of this PR
Converted references from InstanceID to EntityID.
Added macro #if UNITY_6000_3_OR_NEWER to maintain backward compatibility.
Testing status
[Explanation of what’s tested, how tested and existing or new automation tests. Can include manual testing by self and/or QA. Specify test plans. Rarely acceptable to have no testing.]
Documentation status
[Overview of how documentation is affected by this change. If there is no effect on documentation, explain why. Otherwise, state which sections are changed and why.]
Technical risk
low risk
Comments to reviewers
[Info per person for what to focus on, or historical info to understand who have previously reviewed and coverage. Help them get context.]
Package version
[Justification for updating either the patch, minor, or major version according to the semantic versioning rules]