chore: optimize object message flags #3800
Merged
+14
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmandM
approved these changes
Nov 27, 2025
Member
EmandM
left a comment
EmandM
left a comment
There was a problem hiding this comment.
It's a bit of a nitpick with the separate functions so I'm approving now, but I think it might be best to inline those functions
com.unity.netcode.gameobjects/Runtime/Messaging/Messages/CreateObjectMessage.cs
Outdated
Show resolved
Hide resolved
# Conflicts: # com.unity.netcode.gameobjects/CHANGELOG.md
# Conflicts: # com.unity.netcode.gameobjects/CHANGELOG.md
Was breaking the validation exception on unreleased section
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Jira ticket
MTT-13996
Changelog
CreateObjectMessageDocumentation
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Backports
No backport needed.