feat: Make NetworkMetricsPipelineStage public #3853
+84
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// </summary> | ||
| [BurstCompile] | ||
| internal unsafe struct NetworkMetricsPipelineStage : INetworkPipelineStage | ||
| public unsafe struct NetworkMetricsPipelineStage : INetworkPipelineStage |
Member
There was a problem hiding this comment.
I believe that due to this change you should bump package version in package.json to 2.9.0. But vetting test should verify this (will fail if you should bump it)
simon-lemay-unity
requested review from
a team,
EmandM and
NoelStephensUnity
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
As the title says, this PR makes
NetworkMetricsPipelineStagepublic. This is required if you want to use custom drivers that are compatible with the multiplayer tools package as you need to register that pipeline stage before it can be used to create pipelines.Jira ticket
N/A
Changelog
NetworkMetricsPipelineStagefor Unity Transport is now part of the public API. This allows using it in custom implementations ofINetworkStreamDriverConstructorthat want to maintain compatibility with the multiplayer tools package.NullReferenceExceptioninUnityTransportwhen using a customINetworkStreamDriverConstructorthat doesn't use all the default pipelines and the multiplayer tools package is installed.Documentation
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?Backports
N/A