[FIX] Pip install failure due to relativepath not being fulfilled#2
Open
PeterAlabaster wants to merge 1 commit intoUniversalDataTool:masterfrom
Open
[FIX] Pip install failure due to relativepath not being fulfilled#2PeterAlabaster wants to merge 1 commit intoUniversalDataTool:masterfrom
PeterAlabaster wants to merge 1 commit intoUniversalDataTool:masterfrom
Conversation
seveibar
reviewed
Sep 5, 2020
| readme = f.read() | ||
|
|
||
| with open(join(_here, "../LICENSE")) as f: | ||
| with open(join(_here, "LICENSE")) as f: |
There was a problem hiding this comment.
I like the _here variable, great convention!
|
I think this was somehow fixed in 0.1.4 because this worked for me: I also tried it in a docker container. But I'll leave this open for a bit. Can anyone confirm the issue with 0.1.4+? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to install
jac-formatorjac_formatvia pip, I get the following:Collecting jac-format Downloading https://files.pythonhosted.org/packages/78/b1/19ee7688284be98bd950d9d3b946b0f112fcf03f8dbe36b7b3664a6f285d/jac_format-0.1.1.tar.gz Complete output from command python setup.py egg_info: Traceback (most recent call last): File "<string>", line 1, in <module> File "/tmp/pip-install-mmbp3b/jac-format/setup.py", line 7, in <module> with open(join(_here, "../README.md")) as f: IOError: [Errno 2] No such file or directory: '/tmp/pip-install-mmbp3b/jac-format/../README.md'To be clear, I'm not proposing this as the final solution as it's messy to have a duplicate
LICENSEandREADME.md, but this fixed it for me locally, and as I can't raise issues on this repo due to it being a fork, I had to make a PR to raise it.