Skip to content

Conversation

@Foxcapades
Copy link
Collaborator

Changes necessary to support a containerized client host.

WARNING This cannot be merged until:

  1. The client host container is deployed
  2. The client host URI is written to defaults.yml

@Foxcapades Foxcapades self-assigned this Jul 5, 2023
product: '{{ project }}' # product: ClinEpiDB vs. project/model: ClinEpiDB or Gates

# Client Container Config
webapp_host_uri: =c= URI (URL or path) under which the client code container is exposed (if it is a path, it MUST begin with /) TODO SET ME HERE WHEN THE CONTAINER IS DEPLOYED!!!!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this is always "https://{{hostname}}/client-bundle-service", no? Or did we decide to appoint a URL e.g. veupathdb.org and then deal with the CORS issues? (with "client-bundle-service" being a stub name TBD later). You do need to put that extra string in somewhere (i.e. the apache mapping name, like "eda" or "site-search"). Should decide what it will be for the client code service.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now it is this way so that it can be configured to be either a relative path:

webapp_host_uri: /client-bundle-service

or a remote URL for testing with locally hosted client code:

webapp_host_uri: https://f84e-2600-4040-70fa-ee00-9cb2-1473-b230-a66f.ngrok-free.app

If this is undesirable it can be changed when we get the thing deployed, but we will be cutting off our ability to localhost client code to run on a dev server.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to keep this in place.

Also, it might be nice to use a single host for all sites, since users will reap the benefits of caching once across all sites. However, I'm not sure if CORS will become an issue (I think not, but would have to look more closely). We can play with that once the thing is deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants