Allow PROJECT_NAME to override in all cases in wb script
#77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrestel
approved these changes
Oct 14, 2021
Member
jbrestel
left a comment
jbrestel
left a comment
There was a problem hiding this comment.
Wondering if it makes sense to force the user to set the PROJECT_NAME environment variable? That way there is no confusion. (or maybe print a warning if it is getting the project name from tomcat directory name)
Member
Author
|
Sure - we should make sure the behaviour of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I (Bob) found a problem with the
wbscript when running different branded sites from /var/www/EuPathDB/eupathdb.bmaccallumrebuilderworked fine, but this fix stops thewdkXmlstep failing.