Skip to content

Fix language picker showing unsupported languages and add missing Dutch support #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 3 commits into from
+3 −2
Closed

Fix language picker showing unsupported languages and add missing Dutch support #563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57c721b
Initial plan
Copilot Oct 13, 2025
e57c713
Remove defaultLocale from supported languages and add Dutch
Copilot Oct 13, 2025
4ccbc59
Merge branch 'main' into copilot/fix-hungarian-language-setting
VREMSoftwareDevelopment Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/src/main/kotlin/com/vrem/util/LocaleUtils.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ private object SyncAvoid {
val supportedLocales: List<Locale> =
setOf(
BULGARIAN,
DUTCH,
GREEK,
Locale.SIMPLIFIED_CHINESE,
Locale.TRADITIONAL_CHINESE,
Expand All @@ -47,11 +48,11 @@ private object SyncAvoid {
RUSSIAN,
TURKISH,
UKRAINIAN,
Copy link
Owner

@VREMSoftwareDevelopment VREMSoftwareDevelopment Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you expect user of application to switch back to the phone language locale, if it is not part of available application locales?

defaultLocale,
).toList()
}

val BULGARIAN: Locale = Locale.forLanguageTag("bg")
val DUTCH: Locale = Locale.forLanguageTag("nl")
val GREEK: Locale = Locale.forLanguageTag("el")
val POLISH: Locale = Locale.forLanguageTag("pl")
val PORTUGUESE_PORTUGAL: Locale = Locale.forLanguageTag("pt-PT")
Expand Down
2 changes: 1 addition & 1 deletion app/src/test/kotlin/com/vrem/util/LocaleUtilsTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ class LocaleUtilsTest {
val expected: Set<Locale> =
setOf(
BULGARIAN,
DUTCH,
GREEK,
Locale.SIMPLIFIED_CHINESE,
Locale.TRADITIONAL_CHINESE,
Expand All @@ -109,7 +110,6 @@ class LocaleUtilsTest {
RUSSIAN,
TURKISH,
UKRAINIAN,
Locale.getDefault(),
)
// execute
val actual = supportedLanguages()
Expand Down