Merge pull request #830 from adamtheturtle/more-exception-tests

Add a few more exception tests

Author: adamtheturtle

src/vws/exceptions.py

@@ -20,6 +20,21 @@ def __init__(self, response: Response) -> None:
         self.response = response
 
 
+class BadImage(Exception):
+    """
+    Exception raised when Vuforia returns a response with a result code
+    'BadImage'.
+    """
+
+    def __init__(self, response: Response) -> None:
+        """
+        Args:
+            response: The response to a request to Vuforia.
+        """
+        super().__init__()
+        self.response = response
+
+
 class TargetStatusProcessing(Exception):
     """
     Exception raised when Vuforia returns a response with a result code

src/vws/vws.py

@@ -15,6 +15,7 @@
 
 from vws._authorization import authorization_header, rfc_1123_date
 from vws.exceptions import (
+    BadImage,
     ImageTooLarge,
     MetadataTooLarge,
     TargetNameExist,
@@ -99,6 +100,7 @@ def _raise_for_result_code(
         return
 
     exception = {
+        'BadImage': BadImage,
         'ImageTooLarge': ImageTooLarge,
         'MetadataTooLarge': MetadataTooLarge,
         'TargetNameExist': TargetNameExist,

tests/test_add_target.py

@@ -6,10 +6,8 @@
 
 import pytest
 from mock_vws import MockVWS
-from requests import codes
 
 from vws import VWS
-from vws.exceptions import TargetNameExist
 
 
 class TestSuccess:
@@ -51,28 +49,6 @@ def test_add_two_targets(
         client.add_target(name='a', width=1, image=high_quality_image)
 
 
-class TestName:
-    """
-    Tests for the ``name`` parameter to ``add_target``.
-    """
-
-    def test_add_two_targets_same_name(
-        self,
-        client: VWS,
-        high_quality_image: io.BytesIO,
-    ) -> None:
-        """
-        A ``TargetNameExist`` exception is raised after adding two targets with
-        the same name.
-        """
-        client.add_target(name='x', width=1, image=high_quality_image)
-
-        with pytest.raises(TargetNameExist) as exc:
-            client.add_target(name='x', width=1, image=high_quality_image)
-
-        assert exc.value.response.status_code == codes.FORBIDDEN
-
-
 class TestCustomBaseURL:
     """
     Tests for adding images to databases under custom VWS URLs.

tests/test_exceptions.py

@@ -11,8 +11,10 @@
 
 from vws import VWS
 from vws.exceptions import (
+    BadImage,
     ImageTooLarge,
     MetadataTooLarge,
+    TargetNameExist,
     TargetStatusProcessing,
     UnknownTarget,
 )
@@ -88,6 +90,32 @@ def test_request_quota_reached() -> None:
     """
 
 
+def test_bad_image(client: VWS) -> None:
+    """
+    A ``BadImage`` exception is raised when a non-image is given.
+    """
+    not_an_image = io.BytesIO(b'Not an image')
+    with pytest.raises(BadImage) as exc:
+        client.add_target(name='x', width=1, image=not_an_image)
+
+    assert exc.value.response.status_code == codes.UNPROCESSABLE_ENTITY
+
+
+def test_target_name_exist(
+    client: VWS,
+    high_quality_image: io.BytesIO,
+) -> None:
+    """
+    A ``TargetNameExist`` exception is raised after adding two targets with
+    the same name.
+    """
+    client.add_target(name='x', width=1, image=high_quality_image)
+    with pytest.raises(TargetNameExist) as exc:
+        client.add_target(name='x', width=1, image=high_quality_image)
+
+    assert exc.value.response.status_code == codes.FORBIDDEN
+
+
 def test_target_status_processing(
     client: VWS,
     high_quality_image: io.BytesIO,