-
Notifications
You must be signed in to change notification settings - Fork 7
Switch from pre-commit to prek #2774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Replace pre-commit with prek in pyproject.toml dev dependencies - Update .pre-commit-config.yaml to use prek builtin hooks - Remove pre-commit CI configuration (ci: section) - Update GitHub Actions workflow to use prek commands - Update contributing documentation for prek
| uv run --extra=dev pre-commit run --all-files --hook-stage manual --verbose | ||
| uv run --extra=dev prek run --all-files --hook-stage pre-commit --verbose | ||
| uv run --extra=dev prek run --all-files --hook-stage pre-push --verbose | ||
| uv run --extra=dev prek run --all-files --hook-stage manual --verbose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pre-commit-ci/lite-action step not removed as intended
The PR description states "Remove pre-commit-ci/lite-action step" but this step is still present in the workflow. The pre-commit-ci/lite-action is specifically designed to work with pre-commit to auto-fix PRs, not with prek. Since the PR switches to prek, this action won't function as intended and represents either dead code or broken functionality for auto-fixing PRs.
This PR migrates from
pre-committoprek, a faster Rust-based alternative.Changes
pre-commitwithprekin pyproject.toml dev dependenciesci:section)prekcommandsWhy prek?
See https://prek.j178.dev for more information.
Note
Migrates repository linting workflow and tooling from
pre-committoprek.pre-commitdev dependency withprekinpyproject.tomllint.ymlto runuv run ... prek runforpre-commit,pre-push, andmanualstagesdocs/source/contributing.rst) to install and runprekinstead ofpre-commit.pre-commit-config.yamlto setdefault_install_hook_typesto[pre-commit, pre-push]Written by Cursor Bugbot for commit bcb26d1. This will update automatically on new commits. Configure here.