Skip to content

VRClientCoreFactory (and presumably HmdSystemFactory) need to be cdecl to match OpenVR SDK (Closes 8749) #8771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
twhitehead wants to merge 2 commits into
base: proton_10.0
Choose a base branch
from
+4 −4
Open

VRClientCoreFactory (and presumably HmdSystemFactory) need to be cdecl to match OpenVR SDK (Closes 8749) #8771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
841b16b
Revert "vrclient: Mark VRClientCoreFactory, HmdSystemFactory as stdca…
twhitehead Jun 4, 2025
297fe2a
vrclient: HmdSystemFactory and VRClientCoreFactory are cdecl
twhitehead Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions vrclient_x64/vrclient.spec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Generated from vrclient.dll by winedump

1 stdcall HmdSystemFactory(ptr ptr)
2 stdcall VRClientCoreFactory(ptr ptr)
1 cdecl HmdSystemFactory(ptr ptr)
2 cdecl VRClientCoreFactory(ptr ptr)

@ cdecl -private vrclient_init_registry()
4 changes: 2 additions & 2 deletions vrclient_x64/vrclient_main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ static int load_vrclient(void)
return vrclient_loaded;
}

void * __stdcall HmdSystemFactory(const char *name, int *return_code)
void *CDECL HmdSystemFactory(const char *name, int *return_code)
{
struct vrclient_HmdSystemFactory_params params = {.name = name, .return_code = return_code};
TRACE("name: %s, return_code: %p\n", name, return_code);
Expand All @@ -189,7 +189,7 @@ void * __stdcall HmdSystemFactory(const char *name, int *return_code)
return create_win_interface( name, params._ret );
}

void * __stdcall VRClientCoreFactory(const char *name, int *return_code)
void *CDECL VRClientCoreFactory(const char *name, int *return_code)
{
struct vrclient_VRClientCoreFactory_params params = {.name = name, .return_code = return_code};
TRACE("name: %s, return_code: %p\n", name, return_code);
Expand Down