Correct vertical orientation of companion window in hellovr_opengl sample.#1143
Closed
cmbruns wants to merge 3 commits intoValveSoftware:masterfrom
Closed
Correct vertical orientation of companion window in hellovr_opengl sample.#1143cmbruns wants to merge 3 commits intoValveSoftware:masterfrom
cmbruns wants to merge 3 commits intoValveSoftware:masterfrom
Conversation
Author
|
I just noticed there is another pull request that does the same thing, I think. #1113 |
Member
|
Closing as a duplicate of #1113. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The view in the companion window was upside down relative to the view from the HMD. (Unless you are standing on your head, I suppose.)
There are a bunch of ways to fix this. I chose to flip the companion window texture coordinates. It seems like the simplest approach.
This fixes issue #1142