[TF2] Add queue button to contracts#1784
Open
Pandaptable wants to merge 1 commit intoValveSoftware:masterfrom
Open
[TF2] Add queue button to contracts#1784Pandaptable wants to merge 1 commit intoValveSoftware:masterfrom
Pandaptable wants to merge 1 commit intoValveSoftware:masterfrom
Conversation
Contributor
|
If you would like to add it to the post, this would resolve ValveSoftware/Source-1-Games#4406 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the flow of activating contracts and queuing for a match a little nicer. Players no longer have to activate a contract, deselect all maps, search for that one specific map they need, and then finally queue. Instead there is a "Start Search" button in place of the "Activate" button.
The button only shows if the contract is not fully finished and if the contract is active. If required it will automatically select the required maps/modes and then start the casual queue, otherwise it will simply start the queue with the current settings without modifying them. If no maps are selected at all a fallback will load the players saved maps which internally falls back to the entire core category if there are no saved maps.
I also added handling for the usual queue restrictions such as bans, not being party leader, etc. However this includes an ugly hack because
CTFPartyClient::BCanQueueForMatchalso returns an error if there are no maps selected, which for us isn't an issue since we will automatically select at least one map anyways. The only way to check for this case is to manually compare the translation strings, which works fine but isn't nice.The following button would have to be added into
resource/ui/econ/questviewsubpanel.resThe entire modified file is also attached to this PR:
questviewsubpanel.res.txt (had to upload as .txt because github sucks)
Also fixes ValveSoftware/Source-1-Games#4406