[TF2] Fixed several UI being unable to pull paintkit index/pattern name for War Painted weapons#1793
Open
rabscootle wants to merge 2 commits intoValveSoftware:masterfrom
Open
[TF2] Fixed several UI being unable to pull paintkit index/pattern name for War Painted weapons#1793rabscootle wants to merge 2 commits intoValveSoftware:masterfrom
rabscootle wants to merge 2 commits intoValveSoftware:masterfrom
Conversation
Member
|
Minor side note that you can give me a ping and request adjustments if GitHub isn't being reasonable. This and #1792 could have been a git force push to the git branch you were using when you opened #856 and adjusting the description. Having written that, since we've already gotten to this point, there's no point in more housekeeping. |
Contributor
Author
|
Sorry! This is where I am still learning Git, will account for this next time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial fix for ValveSoftware/Source-1-Games#3520
This PR is a newer, less lazy approach to what was previously done in the now-outdated #856.
This PR fixes item names not constructing properly when handling war-painted items in certain UI (Player Status HUD, Target ID):


When paired with #1756, War Paint items should have full feature parity with existing Decorated Weapons and will display War Paint name + Rarity Color in affected UI:

When dealing with dropped weapons, the live TF client currently typically points to static data in the item schema for weapon details, including paint kit index IDs. However, War Paint weapons bypass requiring their own respective schema entries by having attributes applied to individual instances of generic paintkit weapon entries. This approach breaks some UI code where it is expecting the attributes to be on the item schema definition:

Game code has been updated to store a paintkit index within CGameItemDefinition_EconItemInterfaceWrapper, which can be referenced in situations where we cannot point to an actual item instance.
A side effect of this fix is that item qualities will now properly display on constructed item names in the affected UI, which was caused by a missing argument.
