First version of the Report Generation Agent #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrit110
reviewed
Jan 23, 2026
| def execute(self, query: str) -> list[Any]: | ||
| """Execute a SQLite query. | ||
| Args: |
Member
There was a problem hiding this comment.
Nitpicky here, but isn't this google docstring stryle, but then the Returns and other places in the PR looks like numpy style. I prefer numpy style but we should just pick one and be consistent.
| def convert_date(date_str: str) -> str | None: | ||
| """Convert date from 'MM/DD/YY HH:MM' to 'YYYY-MM-DD HH:MM'. | ||
| Args: |
Member
There was a problem hiding this comment.
Same here with docstring style
| ) -> SQLiteSession: | ||
| """Get existing session or create a new one for conversation persistence. | ||
| Args: |
| [tool.ruff] | ||
| include = ["*.py", "pyproject.toml", "*.ipynb"] | ||
| line-length = 88 | ||
| line-length = 120 |
Member
There was a problem hiding this comment.
Not really a suggestion to change but our templates have 88 which is the PEP8/black standard, but i'm fine with 120 for this project. I'm starting to see that 120 is better for github viewing as well just less eye strain lol.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is the first version of the report generation agent. This code was based on the Agent Bootcamp's ReACT RAG code and it brings a lot of code from there.
Future PRs will include more code to do evaluations on this agent.
Clickup Ticket(s): NA
Type of Change
Changes Made
.xlsxfile at the endTesting
Only manual tests performed.
Manual testing details:
.envfile based on the.env.examplefileChecklist