Skip to content

Conversation

@arthurkehrwald
Copy link
Contributor

No description provided.

@freezy
Copy link
Member

freezy commented Feb 23, 2025

Thanks! This however doesn't include the .meta files yet, does it?

@arthurkehrwald
Copy link
Contributor Author

Nah it's WIP

@arthurkehrwald
Copy link
Contributor Author

Just did some tests with Linux and Windows, and both the meta files and the dlls seem to be interchangeable across platforms

@arthurkehrwald arthurkehrwald marked this pull request as ready for review February 23, 2025 21:06
@arthurkehrwald
Copy link
Contributor Author

Ok it's ready I think. Now we don't ship identical binaries for three platforms.

@arthurkehrwald
Copy link
Contributor Author

Forgot about a few meta files

@freezy
Copy link
Member

freezy commented Feb 23, 2025

Cool, let's give this a try!

@freezy freezy merged commit 6dde537 into VisualPinball:master Feb 23, 2025
2 checks passed
@arthurkehrwald
Copy link
Contributor Author

Crap. Didn't work the dlls and yetanotherhttphandler are missing in the deployed package.

@freezy
Copy link
Member

freezy commented Feb 24, 2025

Maybe because your plugins are in Plugins/Plugins? (Also YetAnotherHttpHandler is at YetAnotherHttpHandler/YetAnotherHttpHandler in the artifact.)

In there it seems that all .meta and .dll files are in place, though.

@freezy
Copy link
Member

freezy commented Feb 24, 2025

Instead of

mkdir -p tmp/Plugins
cp -r Plugins tmp/Plugins
mkdir -p tmp/YetAnotherHttpHandler
cp -r YetAnotherHttpHandler tmp/YetAnotherHttpHandler

I'd try:

mkdir -p tmp
cp -r Plugins tmp/
cp -r YetAnotherHttpHandler tmp/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants