implement UVWork to combat resource problems and enhance performance when no default executor is being utilized.#113
Draft
implement UVWork to combat resource problems and enhance performance when no default executor is being utilized.#113
UVWork to combat resource problems and enhance performance when no default executor is being utilized.#113Conversation
…when no default executor is being utilized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
I had an idea about using libuv's thread-pool as a backup mechanism to help eliminate a few resource heavier elements such as the
ThreadPoolExecutorthat was originally utilized for the functions that I have now changed making it possible to do a few faster things when needing to lazily use a function likeasyncio.to_thread(...)There are a few caveats such as not being able to control how many threads are spun up but this new implementation should be very minimal on resources and very beneficial.I added in a test for this function to make sure it runs correctly but now there should no longer be a chain of 3 items before reaching the functions
Orgininally it was
Now it is setup this way making it a lot faster to reach.
Are there changes in behavior for the user?
Is it a substantial burden for the maintainers to support this?
Related issue number
fixes #111
Checklist