Switch wp_safe_redirect back to wp_redirect#67
Conversation
This redirect is *intentionally* open, so must use the regular redirect function.
kadamwhite
left a comment
kadamwhite
left a comment
There was a problem hiding this comment.
Code comment to prevent future issues, maybe?
|
I included the reasoning within the phpcs:ignore line; can add more if it's necessary? |
|
Nah that's good, I didn't scroll far enough right and forgot it could be explained online! |
|
Well, as it happens, I had the wrong sniff code anyway 😒 WPCS is additionally failing due to the (I guess new?) "Short array syntax is not allowed (Generic.Arrays.DisallowShortArraySyntax.Found)" error here, as well as "date() is affected by runtime timezone changes which can cause date/time to be incorrectly displayed. Use gmdate() instead. (WordPress.DateTime.RestrictedFunctions.date_date)". Should I add these errors to the ignored rules? Should we have a separate PR for fixing them? The function change here has broken the entire OAuth system, so it's key that we get it fixed (i.e. the current head version just doesn't work). |
Tackled in #68; I can merge that into this branch and phpcs should pass, if desired. |
|
Going to proceed with merge, fix looks good and the branch management makes sense |
2 participants
This redirect is intentionally open, so must use the regular redirect function.
This was inadvertently broken as part of #58.